Use two producers in all layers. #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcuquine
requested review from
cryptonemo and
dignifiedquire
as code owners
dignifiedquire
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the special handling of layer 1 and uses two producers on all layers. This should never be worse than having only a single producer, and may improve the situation if some configuration is penalized (as possibly observed) by a too-slow producer (perhaps because of slower RAM). I have benchmarked this, and it is no worse (but also no better) than what it replaces on 3970x.
I also cleaned up the
resetfunction inmemory_handling.rs. If we want thedebug!changes from #1295, we could include that here too.