Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filecoin-proofs re-organization #1352

Merged
merged 8 commits into from
Nov 11, 2020
Merged

filecoin-proofs re-organization #1352

merged 8 commits into from
Nov 11, 2020

Conversation

cryptonemo
Copy link
Collaborator

No description provided.

@@ -855,179 +855,3 @@ where

Ok(raw_data.len())
}

#[cfg(test)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets keep these tests in here, they are quite simple and unity

use filecoin_proofs::with_shape;

#[cfg(test)]
mod tests {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for this #[cfg(test)]; mod tests in the tests directory

use filecoin_proofs::parameters::{select_challenges, winning_post_public_params};
use filecoin_proofs::types::{PoStConfig, PoStType};

#[test]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are very simple unit level tests, lets keep them where they were


[dependencies]
storage-proofs = { path = "../storage-proofs", default-features = false }
filecoin-proofs = { path = "../filecoin-proofs", default-features = false }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should have a version too

@dignifiedquire
Copy link
Contributor

there are a bunch of tests for the binaries in filecoin-proofs/tests which will need to be moved too

@cryptonemo cryptonemo changed the title wip: filecoin-proofs re-organization filecoin-proofs re-organization Nov 10, 2020
@cryptonemo cryptonemo marked this pull request as ready for review November 10, 2020 16:09
@cryptonemo
Copy link
Collaborator Author

Resolves #1344 and partially addresses #1349 (regarding filecoin-proofs only)

@cryptonemo cryptonemo merged commit 5c91282 into master Nov 11, 2020
@cryptonemo cryptonemo deleted the fp-organize branch November 11, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants