-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filecoin-proofs re-organization #1352
Conversation
filecoin-proofs/src/fr32.rs
Outdated
@@ -855,179 +855,3 @@ where | |||
|
|||
Ok(raw_data.len()) | |||
} | |||
|
|||
#[cfg(test)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets keep these tests in here, they are quite simple and unity
filecoin-proofs/tests/constants.rs
Outdated
use filecoin_proofs::with_shape; | ||
|
||
#[cfg(test)] | ||
mod tests { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for this #[cfg(test)]; mod tests
in the tests
directory
filecoin-proofs/tests/parameters.rs
Outdated
use filecoin_proofs::parameters::{select_challenges, winning_post_public_params}; | ||
use filecoin_proofs::types::{PoStConfig, PoStType}; | ||
|
||
#[test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are very simple unit level tests, lets keep them where they were
fil-proofs-param/Cargo.toml
Outdated
|
||
[dependencies] | ||
storage-proofs = { path = "../storage-proofs", default-features = false } | ||
filecoin-proofs = { path = "../filecoin-proofs", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these should have a version too
there are a bunch of tests for the binaries in |
refactor: move circuit info to fil-proofs -tooling
e1a766d
to
9cf3bef
Compare
No description provided.