Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PoR no public input gadget #1374

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Conversation

DrPeterVanNostrand
Copy link
Contributor

@DrPeterVanNostrand DrPeterVanNostrand commented Nov 23, 2020

This PR adds a PoR gadget which does not add a public input for the PoR challenge. This allows the caller circuit to pack multiple challenges into a single public input.

This gadget may be integrated into SDR (with some refactoring) and/or used in NSE window-post's window-tree PoR's.

porcuquine
porcuquine previously approved these changes Nov 24, 2020
Copy link
Collaborator

@porcuquine porcuquine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

storage-proofs/core/src/gadgets/por.rs Outdated Show resolved Hide resolved
@dignifiedquire
Copy link
Contributor

@DrPeterVanNostrand any reason this is a draft?

@DrPeterVanNostrand
Copy link
Contributor Author

@dignifiedquire not really, but I didn't know if we wanted to merge it without integrating it someplace

@DrPeterVanNostrand DrPeterVanNostrand marked this pull request as ready for review November 24, 2020 15:48
porcuquine
porcuquine previously approved these changes Nov 24, 2020
@dignifiedquire dignifiedquire merged commit 29d39ad into master Dec 1, 2020
@dignifiedquire dignifiedquire deleted the por-no-pub-input-gadget branch December 1, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants