fix tree-c and tree-r-last generation in GPU mode #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qy3u
requested review from
cryptonemo,
dignifiedquire and
porcuquine
as code owners
porcuquine
approved these changes
Nov 24, 2020
There was a problem hiding this comment.
You're absolutely right. Thank you for catching this.
I verified the problem and that this fixes.
@dignifiedquire When we get get GPU tests set up in CI, we should make sure the batch sizes are set small enough to ensure multiple batches are required on the small sectors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will only 'add_columns' once for each tree and then jump to next tree in current implemention.