-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: put checkout_cores test behind a single-threaded feature #1383
Conversation
.circleci/config.yml
Outdated
@@ -147,6 +147,7 @@ jobs: | |||
ulimit -u 20000 | |||
ulimit -n 20000 | |||
cargo +<< pipeline.parameters.nightly-toolchain >> -Zpackage-features test --all --verbose --release lifecycle -- --ignored --nocapture | |||
cargo +<< pipeline.parameters.nightly-toolchain >> -Zpackage-features test --features single-threaded --release checkout_cores -- --test-threads=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is missing the --all
package specifier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, that's the purpose of this PR. The all is performed, followed by the single checkout_cores test that is isolated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but it still needs to select a package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI log shows what I see locally, which is the single test running (after the all): https://app.circleci.com/pipelines/github/filecoin-project/rust-fil-proofs/2838/workflows/c44d3b1c-e69e-43cc-8c06-6c4e533ccf92/jobs/62773
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, adding the package is more direct, I'll change that (just tried locally).
Currently, the sdr checkout test is done on the pairing side and not mirrored on the blst side. I don't think there's any need to run it more than once. Should it be moved out to a separate job entirely? I only really want to know if it's failing for some reason on CI. |
feat: add checkout_cores test to CI, run single threaded doc: fix typo
3e86037
to
554a404
Compare
feat: add checkout_cores test to CI, run single threaded
doc: fix typo
A possible way to address #1378