Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move fr32 into its own crate #1387

Merged
merged 1 commit into from
Dec 14, 2020
Merged

refactor: move fr32 into its own crate #1387

merged 1 commit into from
Dec 14, 2020

Conversation

DrPeterVanNostrand
Copy link
Contributor

Moves storage-proofs::fr32 into it's own crate.

Issue #1343

@DrPeterVanNostrand DrPeterVanNostrand mentioned this pull request Dec 4, 2020
Closed
@dignifiedquire
Copy link
Contributor

There are more things in filecoin-proofs fr32.rs and fr32_reader.rs, can you pull those in too please?

@DrPeterVanNostrand
Copy link
Contributor Author

@dignifiedquire yup, np

@DrPeterVanNostrand DrPeterVanNostrand force-pushed the fr32-subcrate branch 6 times, most recently from f48e519 to 5e45dad Compare December 9, 2020 16:43
dignifiedquire
dignifiedquire reviewed Dec 9, 2020
View reviewed changes
fr32/Cargo.toml Outdated Show resolved Hide resolved
dignifiedquire
dignifiedquire suggested changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please enable ci for the new crate

@DrPeterVanNostrand DrPeterVanNostrand changed the title refactor: move storage-proofs fr32.rs into its own crate refactor: move fr32 into its own crate Dec 9, 2020
@cryptonemo
Copy link
Collaborator

@DrPeterVanNostrand When you rebase and push, the CI should complete as expected (at least the phase2 related jobs that don't exist any longer won't be required)

dignifiedquire
dignifiedquire suggested changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost, just some cargo feature updates missing

storage-proofs/post/Cargo.toml Outdated Show resolved Hide resolved
@dignifiedquire dignifiedquire merged commit b05ac9d into master Dec 14, 2020
@dignifiedquire dignifiedquire deleted the fr32-subcrate branch December 14, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dignifiedquire dignifiedquire dignifiedquire approved these changes

@cryptonemo cryptonemo Awaiting requested review from cryptonemo cryptonemo is a code owner

@porcuquine porcuquine Awaiting requested review from porcuquine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DrPeterVanNostrand @dignifiedquire @cryptonemo