Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move phase2 code out of rust-fil-proofs #1388

Merged
merged 2 commits into from
Dec 9, 2020
Merged

Conversation

cryptonemo
Copy link
Collaborator

The phase2 code has been moved here: https://github.com/filecoin-project/filecoin-phase2

When this PR is acceptable and the phase2 repo looks ok, I'll cut a patch release of phase2.

@cryptonemo
Copy link
Collaborator Author

cryptonemo commented Dec 8, 2020

Addresses #1379 by fixing the ignored tests in the separate phase2 repo (adds required input file to repo). That new repo also disables building and running of the broken doc tests, but preserves them for reference.

@cryptonemo cryptonemo closed this Dec 8, 2020
@cryptonemo cryptonemo reopened this Dec 8, 2020
@dignifiedquire
Copy link
Contributor

@cryptonemo could you please do the move such that the new repo contains the existing git history? otherwise this looks good to me

@dignifiedquire
Copy link
Contributor

@vmx
Copy link
Contributor

vmx commented Dec 9, 2020

@cryptonemo if you've problems with the "preserve the history", let me know. I've done such things quite a bit in the past (though I also need to google around and look things up, so I probably won't be faster than you doing it yourself :)

@cryptonemo
Copy link
Collaborator Author

https://github.com/filecoin-project/filecoin-phase2 is updated.

Does anyone remember how to change the CI to not require jobs that are missing?

@dignifiedquire
Copy link
Contributor

Does anyone remember how to change the CI to not require jobs that are missing?

it is under branch protection in the settings

@dignifiedquire
Copy link
Contributor

@cryptonemo please make sure CI is setup on the new repo

@cryptonemo
Copy link
Collaborator Author

CI enabled on new repo.

@cryptonemo cryptonemo merged commit c59743e into master Dec 9, 2020
@cryptonemo cryptonemo deleted the move-phase2 branch December 9, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants