Fix merkle bench for poseidon hashing #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptonemo
requested review from
dignifiedquire and
porcuquine
as code owners
cryptonemo
commented
Dec 14, 2020
| .map(|x| { | ||
| <Bls12 as ff::ScalarEngine>::Fr::from_repr(x.0).expect("from_repr failure") | ||
| .enumerate() | ||
| .map(|(i, x)| { |
There was a problem hiding this comment.
Anyone have a preference on this enumerate? It was helpful with debugging, but if there are perf reasons to ditch it, it's no longer needed.
|
|
||
| fn merkle_benchmark_poseidon(c: &mut Criterion) { | ||
| #[cfg(feature = "big-sector-sizes-bench")] | ||
| let params = vec![64]; |
There was a problem hiding this comment.
this should have the larger numbers in there
cryptonemo
force-pushed
the
fix-merkle-bench
branch
from
4810db6
to
5616d4e
Compare
dignifiedquire
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.