-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor param binaries #1392
Refactor param binaries #1392
Conversation
e913a9a
to
7b845e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Nice, thank you guys for reading through it. If no one has an objection, I am going to rebase this into a single commit before merging (cc. @cryptonemo @dignifiedquire) |
Manually, or using the 'squash and merge'? I recommend the latter. |
I was going to do a manual rebase, but it doesn't matter. I'll squash and merge. |
Changes
rust-fil-logger
everywhere.clap
tostructopt
.filecoin_proofs::param::choose_from()
todialoguer::{MultiSelect, Select}
.Commit 7758886 (
fakeipfsadd
)Commit e1bd75b (
paramcache
)--params-for-sector-sizes
to--sector-sizes
Clone
for circuits:StackedCircuit
, SDRProof
,FallbackPoStCircuit
, FallbackPoStSector
Clone
is required because we can't reliably#[derive(Clone)]
on generic structs havingPhantomData
fields.Clone
-ing circuits makes it so that we don't need to call::blank_circuit()
every time we need a circuit instance.Commit 4627bd1 (
paramfetch
)--params-for-sector-sizes
to--sector-sizes
ipget
to latest version (v0.4.0
to0.6.0
).fil-proofs-param/tests/paramfetch/prompts_to_fetch.rs
tofil-proofs-param/tests/paramfetch/mod.rs
.Commit bfb3811 (
parampublish
)--all
to--list-all
(used for listing all parameter files in the cache dir).FileInfo
struct to store a each parameter's: filename, param-id, file extension, and parameter version (so those strings do not have to be repeatedly derived, also makes filtering and sorting easier).is_well_formed_filename()
to ensure that a parameter filename are in the expected format.Commit e913a9a
filecoin_proofs::param::{choose, choose_from}
in favor ofdialoguer::{MultiSelect, Select}
.