Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use latest version of dialoguer #1447

Merged
merged 1 commit into from
Apr 20, 2021
Merged

fix: use latest version of dialoguer #1447

merged 1 commit into from
Apr 20, 2021

Conversation

vmx
Copy link
Contributor

@vmx vmx commented Apr 20, 2021

The older version of dialoguer had a dependency on zerioize that
was yanked, hence making builds fail.

I've tried out some of the tools using dialoguer locally.

  • circuitinfo: seems to do the correct thing interface wise, but it didn't print any information for me. I can't tell if it worked before or not
  • paramcache: the output isn't as smooth I remembered it (but I can't tell if it was the same prior to this change, but i suspect it was), but it seems to work properly
  • paramfetch: seems to work as expected

So I think this PR is OK to be merged.

The older version of dialoguer had a dependency on zerioize that
was yanked, hence making builds fail.
@vmx vmx requested a review from cryptonemo April 20, 2021 10:52
@vmx vmx merged commit e35a4a5 into master Apr 20, 2021
@vmx vmx deleted the update-dialoguer08 branch April 20, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants