Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable multicore sdr on os x where it's not supported #1452

Closed
wants to merge 2 commits into from

Conversation

cryptonemo
Copy link
Collaborator

No description provided.

@cryptonemo
Copy link
Collaborator Author

Is anyone able to verify that this is the case? Has multicore sdr been tested on OS X?

@cryptonemo
Copy link
Collaborator Author

cryptonemo commented Apr 29, 2021

Is anyone able to verify that this is the case? Has multicore sdr been tested on OS X?

I do see a panic on our darwin CI machine when enabled, but am curious if this was ever intended to work on OS X (I realize it's not the ideal runtime target, just curious).

Interestingly, M1 appears to work ok as-is (assuming m1-portable branch is used: #1444), so I may update THAT PR to leave that enabled.

@dignifiedquire
Copy link
Contributor

SDR multicore should work on macs, I don' think we should generally disable it. There might be issues with the specific hardware on CI

@cryptonemo
Copy link
Collaborator Author

SDR multicore should work on macs, I don' think we should generally disable it. There might be issues with the specific hardware on CI

Alternatively, we could remove the CI darwin run as required as it's been more or less consistently failing lately (it used to be hit or miss). It may actually have to do with what else is running on CI at the time, not sure.

@cryptonemo
Copy link
Collaborator Author

Closed in favor of #1454

@cryptonemo cryptonemo closed this May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants