Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct aggregate proof serialization format #1475

Merged
merged 1 commit into from
Jun 17, 2021
Merged

fix: use correct aggregate proof serialization format #1475

merged 1 commit into from
Jun 17, 2021

Conversation

cryptonemo
Copy link
Collaborator

No description provided.

porcuquine
porcuquine approved these changes Jun 17, 2021
View reviewed changes
Copy link
Collaborator

@porcuquine porcuquine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks straightforward. On the assumption that this is directly exercised by tests which show that these functions round-trip as expected, this seems fine to me.

@cryptonemo cryptonemo merged commit a2f647b into master Jun 17, 2021
@cryptonemo cryptonemo deleted the fix-agg-serialization branch June 17, 2021 20:22
@arajasek arajasek mentioned this pull request Jun 17, 2021
Closed
@dignifiedquire
Copy link
Contributor

@cryptonemo can we add some tests to check that the sizes match exactly hard coded values, to avoid surprises.

@cryptonemo
Copy link
Collaborator Author

@cryptonemo can we add some tests to check that the sizes match exactly hard coded values, to avoid surprises.

For lack of a better place (i.e. a separate PR), I added it here: 336e2fd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikkolasg nikkolasg nikkolasg approved these changes

@porcuquine porcuquine porcuquine approved these changes

@dignifiedquire dignifiedquire Awaiting requested review from dignifiedquire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cryptonemo @dignifiedquire @porcuquine @nikkolasg