feat: swap out default backend from pairing to blst #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
previously approved these changes
Jul 26, 2021
|
Resolves #1438 |
|
Requires |
cryptonemo
force-pushed
the
swap-pairing-for-blst
branch
from
e4b4d66
to
9fd8f38
Compare
|
This PR will need a new review as it's getting ready since a number of deps are changing, including |
vmx
reviewed
Jul 30, 2021
| let mut tree_builder = TreeBuilder::<Tree::Arity>::new( | ||
| #[cfg(feature = "gpu")] | ||
| Some(BatcherType::OpenCL), | ||
| batcher, |
There was a problem hiding this comment.
The config flag in the line above is not needed as the whole function is only enabled when the gpu feature is enabled.
There was a problem hiding this comment.
Agreed, I noticed it was there, so preserved it for now (i.e. left alone). Can remove before merging.
feat: update neptune to a branch with updated bellman
fix: rename arg var and remove unneeded cfg
cryptonemo
force-pushed
the
swap-pairing-for-blst
branch
from
f81494e
to
b523a87
Compare
DrPeterVanNostrand
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires filecoin-project/bellperson#203