chore: improve 'PRODUCER NOT READY' log #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptonemo
reviewed
Jul 28, 2021
| @@ -322,9 +322,9 @@ fn create_layer_labels( | |||
|
|
|||
| while producer_val < i { | |||
| if !printed { | |||
| debug!("PRODUCER NOT READY! {}", i); | |||
| trace!("PRODUCER NOT READY! {}", i); | |||
There was a problem hiding this comment.
I also see this logged thousands of time per run. I'd argue this individual log line could be removed. Perhaps a map of the i value to specific count may be needed if this information is important and it could be logged at the end along with the total count?
There was a problem hiding this comment.
A map of i to count may be too large to be logged. I agree with remove this line.
cryptonemo
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I met some miner reports that there are too many (sometimes even millions of) "PRODUCER NOT READY" logs for each layer.
I think we can lower its log level.