Serialize parent's cache generation and access #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add a test for this to ensure there's no corruption
| Ok(c) => Ok(c), | ||
| Ok(c) => { | ||
| generated.insert(generation_key); | ||
| drop(generated); |
There was a problem hiding this comment.
this is not really needed, as it will be dropped as soon as the function ends
There was a problem hiding this comment.
I thought an explicit drop made sense at the time, but agreed, it's not needed
dignifiedquire
previously approved these changes
Aug 19, 2021
|
Resolves #1495 |
fix: ensure test doesn't remove a file another thread is using
cryptonemo
force-pushed
the
parallel-parents-cache-gen
branch
from
263d3e5
to
fcfdc5b
Compare
dignifiedquire
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.