fix: use GPU tree builder only for Poseidon hashes #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptonemo
previously approved these changes
Oct 5, 2021
dignifiedquire
previously approved these changes
Oct 5, 2021
The GPU tree builder (Neptune) only supports Poseidon hashes. Switch to the CPU tree builder if other hash algorithms are used (which isn't the case in Filecoin at the moment). Closes #1512.
vmx
force-pushed
the
tree-builder-fix-type-id
branch
from
d863a06
to
0ebe6b7
Compare
|
Sorry for the hassle, I thought the merging is smoother. Please re-approve and I'll merge once the CI is green. |
dignifiedquire
approved these changes
Oct 5, 2021
vmx
added a commit
that referenced
this pull request
Oct 6, 2021
The current code expected that if the GPU-based tree building is enabled,
that there also is a working GPU available. When it is not, it panics.
This commit adds a fallback to CPU in case selecting a working GPU fails.
It can be verified by running
FIL_PROOFS_USE_GPU_TREE_BUILDER=1 cargo test --test stacked_vanilla test_stacked_porep_prove_verify
if the machine has no working Nvidia or AMD GPU.
Fixes #1515.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GPU tree builder (Neptune) only supports Poseidon hashes. Switch
to the CPU tree builder if other hash algorithms are used (which isn't
the case in Filecoin at the moment).
Closes #1512.