Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: benchy: print help if no command is given #1527

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Conversation

vmx
Copy link
Contributor

@vmx vmx commented Oct 15, 2021

Prior to this change benchy will panic if there were no options given.
Now it prints the help.

I wanted to do this for years, finally I did.

Copy link
Collaborator

@cryptonemo cryptonemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but can it be (re)based again latest?

Prior to this change benchy will panic if there were no options given.
Now it prints the help.
@vmx
Copy link
Contributor Author

vmx commented Oct 15, 2021

Oh dear, why didn't I update to master when I created it?

@cryptonemo cryptonemo merged commit 2065052 into master Oct 15, 2021
@cryptonemo cryptonemo deleted the benchy-help branch October 15, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants