fix: correctly set cache path for empty sector update proofs #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
requested review from
cryptonemo,
dignifiedquire,
DrPeterVanNostrand and
vmx
as code owners
|
@arajasek Good catch! It looks like the issue is that we get the t_aux from one place, and persist it to another (after encode/remove/etc). When re-instantiating after it's persisted to the new location, the cache path may be incorrect, so explicitly setting it at that time is preferred. |
cryptonemo
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly intended to indicate where I think a bug exists
I'm not entirely sure whether this is the right fix, but something around the cache path here seems to be wrong, causing most users on SnapNet to be unable to upgrade their sectors (see filecoin-project/lotus#7968).
We may only want to be setting the path in some of the use cases for this method.