fix wrong sector size on readme.md #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshidama323
requested review from
dignifiedquire,
cryptonemo,
DrPeterVanNostrand and
vmx
as code owners
cryptonemo
reviewed
Feb 10, 2022
README.md
Outdated
| > cargo run --release --bin benchy -- merkleproofs --size 2 | ||
| > cargo run --release --bin benchy -- winning-post --size 2 | ||
| > cargo run --release --bin benchy -- window-post --size 2 | ||
| > cargo run --release --bin benchy -- merkleproofs --size 2048 |
There was a problem hiding this comment.
There is still a typo here on . Verifying size change is correct currently, as at one point we intentionally multiplied by 1KiB.--merkleproofs
There was a problem hiding this comment.
I'd suggest the change of using sizes such as 2KiB, as that notation is supported.
cryptonemo
approved these changes
Feb 16, 2022
|
Thank you @woshidama323! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.