chore: CI: don't always run test_seal_lifecycle_upgrade #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It probably was a debug left-over from the sector upgrade work. The `test_seal_lifecycle_upgrade` test is included when running with the default test arguments, so there's no need to mention it separately. It was also run in the non-ignore case. There's no point of running it twice.
vmx
requested review from
dignifiedquire,
cryptonemo and
DrPeterVanNostrand
as code owners
|
Have you verified in CI logs that it was run twice? |
Yes. Search for |
cryptonemo
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It probably was a debug left-over from the sector upgrade work. The
test_seal_lifecycle_upgradetest is included when running withthe default test arguments, so there's no need to mention it separately.
It was also run in the non-ignore case. There's no point of running
it twice.