chore: use memmap2 instead of mapr #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storojs72
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Thanks. I believe it is good to merge this PR after this one - #1625 that fixes Darwin CI job execution. Plus it looks like we can now archive https://github.com/filecoin-project/mapr repository as it is not used anymore. Who can do that (I cannot unfortunately...)? May be @dignifiedquire ?
dignifiedquire
approved these changes
Aug 18, 2022
cryptonemo
approved these changes
Aug 22, 2022
`memmap2` is maintained and contains all features from `mapr`, so using the `mapr` fork of `memmap` is no longer needed. Here are the changes in detail: - `map_anon()` in `memmap2` is always `MAP_PRIVATE`, so a call to `private()` is no longer needed. - using `mlock` is similar to the `MAP_LOCKED` setting, hence it is no longer set. In `memmap2` the `mlock()` is just called `lock()`. - `MAP_PRIVATE` is done via `map_copy_read_only()`.
Closed
vmx
added a commit
that referenced
this pull request
Sep 15, 2022
`memmap2` is maintained and contains all features from `mapr`, so using the `mapr` fork of `memmap` is no longer needed. Here are the changes in detail: - `map_anon()` in `memmap2` is always `MAP_PRIVATE`, so a call to `private()` is no longer needed. - using `mlock` is similar to the `MAP_LOCKED` setting, hence it is no longer set. In `memmap2` the `mlock()` is just called `lock()`. - `MAP_PRIVATE` is done via `map_copy_read_only()`.
This was referenced Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memmap2is maintained and contains all features frommapr, so usingthe
maprfork ofmemmapis no longer needed.Here are the changes in detail:
map_anon()inmemmap2is alwaysMAP_PRIVATE, so a call toprivate()is no longer needed.
mlockis similar to theMAP_LOCKEDsetting, hence it is no longerset. In
memmap2themlock()is just calledlock().MAP_PRIVATEis done viamap_copy_read_only().