test: make sure that WindowPoSt also works on read-only files #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adapts the test to make the generated files read-only before a WindowPoSt is performed. This simulates the use case when you mount your sectors read-only after generation.
cryptonemo
previously approved these changes
Sep 15, 2022
storojs72
reviewed
Sep 16, 2022
storojs72
reviewed
Sep 16, 2022
There was a problem hiding this comment.
We also need to test winning_post similarly - as it was mentioned in the original issue: #1629 (comment)
|
Kicked off the CI again now that |
Not a bad idea, but not a requirement for this PR |
The Window PoSt tests were already working on read-only files where possible, do the same for Winning PoSt.
|
It now makes the replica files read-only and also tests Winning PoSt the same way. |
cryptonemo
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adapts the test to make the generated files read-only before a WindowPoSt is performed. This simulates the use case when you mount your sectors read-only after generation.