Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: copy_parents_data only needs base parents #1660

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

zhiqiangxu
Copy link
Contributor

@zhiqiangxu zhiqiangxu commented Feb 24, 2023

copy_parents_data_inner only uses base parents, so there's no need to fetch extension parents at the caller side.

vmx
vmx previously approved these changes Feb 24, 2023
Copy link
Contributor

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That looks correct to me. But I'd like to have other team members double-check as this is such a central piece.

@zhiqiangxu Thanks for your contributions. You also always put helpful context in your PR description. It would be cool if you could also put it into the commit message next time (then it even automatically becomes the PR description).

@zhiqiangxu
Copy link
Contributor Author

Thanks! That looks correct to me. But I'd like to have other team members double-check as this is such a central piece.

@zhiqiangxu Thanks for your contributions. You also always put helpful context in your PR description. It would be cool if you could also put it into the commit message next time (then it even automatically becomes the PR description).

I just modified the commit message and re-pushed the branch :)

Copy link
Contributor

@DrPeterVanNostrand DrPeterVanNostrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good to me.

copy_parents_data_inner only uses base parents, so there's no need to fetch extension parents at the caller side.
@vmx
Copy link
Contributor

vmx commented Mar 8, 2023

@cryptonemo we should also merge that one. As you've most PR open, I'll leave it up to you when to merge.

@vmx vmx merged commit b1779c1 into filecoin-project:master Apr 25, 2023
@vmx
Copy link
Contributor

vmx commented Apr 25, 2023

@zhiqiangxu sorry for taking so long, this PR slipped my attention. It's now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants