Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix the open 'grindability issue' #1661

Merged
merged 7 commits into from
Mar 8, 2023
Merged

feat: fix the open 'grindability issue' #1661

merged 7 commits into from
Mar 8, 2023

Conversation

cryptonemo
Copy link
Collaborator

Some more details here:
#1270

@cryptonemo cryptonemo changed the title feat: minimal changes to fix the open 'grindability issue' feat: fix the open 'grindability issue' Feb 24, 2023
DrPeterVanNostrand
DrPeterVanNostrand previously approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@DrPeterVanNostrand DrPeterVanNostrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. My only optional change would be the naming used in get_challenge_index.

vmx
vmx requested changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor things, except for the one comment about the exhaustive pattern matching.

filecoin-proofs/src/api/post_util.rs Outdated Show resolved Hide resolved
filecoin-proofs/tests/api.rs Outdated Show resolved Hide resolved
filecoin-proofs/tests/api.rs Outdated Show resolved Hide resolved
filecoin-proofs/tests/api.rs Outdated Show resolved Hide resolved
filecoin-proofs/tests/api.rs Outdated Show resolved Hide resolved
storage-proofs-post/src/fallback/utils.rs Outdated Show resolved Hide resolved
@cryptonemo
Copy link
Collaborator Author

Fun, the openssl-src package is failing clippy and causing CI issues 😓

@cryptonemo
Copy link
Collaborator Author

Fun, the openssl-src package is failing clippy and causing CI issues sweat

Hrm, we could just update rust-toolchain to something later like 1.67.1. Not a bad idea IMO, but then we have a host of other clippy issues incoming. Let me see about a separate PR updating it and then possibly rebasing this after.

@vmx vmx self-requested a review March 1, 2023 14:13
vmx
vmx previously approved these changes Mar 1, 2023
View reviewed changes
@arajasek arajasek mentioned this pull request Mar 1, 2023
Closed
13 tasks
@cryptonemo
Copy link
Collaborator Author

Resolves #1270

@cryptonemo cryptonemo dismissed stale reviews from DrPeterVanNostrand and vmx via bdba9c4 March 6, 2023 20:56
vmx
vmx previously approved these changes Mar 7, 2023
View reviewed changes
Kubuxu
Kubuxu approved these changes Mar 8, 2023
View reviewed changes
Copy link

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@cryptonemo cryptonemo merged commit e4bbde6 into master Mar 8, 2023
@cryptonemo cryptonemo deleted the grindability-fix branch March 8, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrPeterVanNostrand DrPeterVanNostrand DrPeterVanNostrand approved these changes

@Kubuxu Kubuxu Kubuxu approved these changes

@vmx vmx vmx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Network nv19
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cryptonemo @vmx @Kubuxu @DrPeterVanNostrand