fix: make builds on stable and aarch64 possible #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using Rust nightly we are able to enable an optimization for aarch64. With this change it's now possible to compile for aarch64 on stable rust, while the optimization is still enabled when compiled with nightly. A similar fix was made for bellperson at filecoin-project/bellperson#269 This fix can be tested even on x86_64 on Linux with cross compiling for aarch64: cargo build --target aarch64-unknown-linux-gnu Fixes #1652.
We no longer need to run nightly on CI.
|
I've verified locally that a different code path is used when compiling with stable Rust or nightly for aarch64. |
DrPeterVanNostrand
requested changes
Mar 10, 2023
cryptonemo
approved these changes
Mar 10, 2023
DrPeterVanNostrand
approved these changes
Mar 10, 2023
This was referenced May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Rust nightly we are able to enable an optimization for aarch64.
With this change it's now possible to compile for aarch64 on stable rust,
while the optimization is still enabled when compiled with nightly.
A similar fix was made for bellperson at
filecoin-project/bellperson#269
This fix can be tested even on x86_64 on Linux with cross compiling
for aarch64:
Fixes #1652.