Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: benchy window-post add parallels tasks #1686

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

lovel8
Copy link
Contributor

@lovel8 lovel8 commented Mar 24, 2023

feat: benchy window-post add parallels tasks

@vmx
Copy link
Contributor

vmx commented Mar 24, 2023

Can you please explain a bit more about this feature? Wouldn't it be the same as running benchy manually in parallel?

@vmx
Copy link
Contributor

vmx commented Mar 24, 2023

In regards to CI not running. CircleCI is weird. You probably have CircleCI configured to run on the fork you have. In order to get CircleCI run here, you'd need to unfollow your fork in the CircleCI UI.

@lovel8
Copy link
Contributor Author

lovel8 commented Mar 27, 2023

Can you please explain a bit more about this feature? Wouldn't it be the same as running benchy manually in parallel?

  1. The functions are the same, but it is more convenient to run only one program and run 30 programs at the same time in each concurrent test.
  2. The concurrency test runs only one program, which is consistent with the actual business concurrency usage, and the test results are more in line with expectations.

@lovel8
Copy link
Contributor Author

lovel8 commented Mar 27, 2023

In regards to CI not running. CircleCI is weird. You probably have CircleCI configured to run on the fork you have. In order to get CircleCI run here, you'd need to unfollow your fork in the CircleCI UI.

image

@vmx
Copy link
Contributor

vmx commented Mar 27, 2023

@lovel8 were you always not following or did you change to not follow? In case you changed, can you try to push again? Easiest is to do a git commit --amend and then push that new commit.

In case you didn't ever follow your own fork, then I've no idea what the problem is. In the meantime I've pushed that branch so that CI runs. You can see the results here: https://app.circleci.com/pipelines/github/filecoin-project/rust-fil-proofs/4656/workflows/9177d9c2-9f2d-478d-a3e5-0c654698a49a

Copy link
Contributor

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cryptonemo can you please also have a look at this PR? It sounds good to me.

@vmx vmx merged commit fcb22da into filecoin-project:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants