-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Benchy test without git code cannot output result #1688
Conversation
79edf81
to
0089fdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about making the Git metadata optional at
git: GitMetadata, |
It could be changed to Option<GitMetadata>
and if retrieving the data fails, it would just be None.
If the git information is empty, the purpose of the code corresponding to this parameter will not be achieved. |
Thanks for the explanation. I only though about the case where you have something like a source tarball without a |
3643141
to
166d1b8
Compare
2661b1b
to
320d5b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Things look good. Once you've removed the benchy
binary from the commit, it's good to go.
fix: Update current last version vergen@V8.1.1
320d5b2
to
aeff779
Compare
Description: When the benchy program is generated on the compilation server and copied to a non-git code server for testing, the report result cannot be output.