feat: add function to decode a range from an updated sector #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it's only possible to decode a full empty updated sector. With this new function, it's possible to also decode only a range. You can pass in any readable stream, i.e. file descriptors but also pipes or even slices. BREAKING CHANGE: `EmptySectorUpdate::decode_from` no longer takes `h` as argument.
If there would only be one generic for the input files, they both would need to have the same type. E.g. you couldn't pass in a file and a slice. With separate generics that's possible.
DrPeterVanNostrand
requested changes
May 17, 2023
DrPeterVanNostrand
requested changes
May 17, 2023
The ChunkIterator is a higher level primitive that is only used on the API surface, hence moving it out of the core.
cryptonemo
previously approved these changes
May 19, 2023
Hard-code `h` only on the API, not on the proofs level.
DrPeterVanNostrand
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's only possible to decode a full empty updated sector. With this new function, it's possible to also decode only a range.
You can pass in any readable stream, i.e. file descriptors but also pipes or even slices.
BREAKING CHANGE:
EmptySectorUpdate::decode_fromno longer takeshas argument.This is based on @DrPeterVanNostrand work at #1687.
In case you wonder why the
rhos()function was refactored. This makes it easier callable, as it now only needs the number of nodes as input. The newRhoswill then also be used for the upcoming binaries.