Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove with_feature #1733

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix: remove with_feature #1733

merged 1 commit into from
Dec 1, 2023

Conversation

vmx
Copy link
Contributor

@vmx vmx commented Oct 31, 2023

The PoRepConfig::with_feature() function is not used anywhere, hence remove it.

@vmx
fix: remove with_feature
356c950 
The `PoRepConfig::with_feature()` function is not used anywhere, hence
remove it.
cryptonemo
cryptonemo approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@cryptonemo cryptonemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we use more features in the future, this is a forward thinking API since we need decent ways to enable them.

@vmx vmx merged commit bdd0d35 into master Dec 1, 2023
32 checks passed
@vmx vmx deleted the remove-with-feature branch December 1, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptonemo cryptonemo cryptonemo approved these changes

@DrPeterVanNostrand DrPeterVanNostrand DrPeterVanNostrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmx @DrPeterVanNostrand @cryptonemo