refactor: get number of layers from private inputs #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrPeterVanNostrand
previously approved these changes
Nov 10, 2023
vmx
force-pushed
the
stacked-circuit-num-layers
branch
from
dab8b31
to
a1843e5
Compare
Instead of passing in the number of layers through the public params, get the number of layers from the private inputs that are required anyway. The number of layers equals the number of columns of a columns proof.
vmx
force-pushed
the
stacked-circuit-remove-num-layers
branch
from
d08ea73
to
01eaf2d
Compare
DrPeterVanNostrand
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing in the number of layers through the public params, get the number of layers from the private inputs that are required anyway. The number of layers equals the number of columns of a columns proof.
I first wasn't really convinced that it makes sense, but after seeing that now
circuit()doesn't need the public params anymore it looks like a win to me.