feat: benchy: add API features flag #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptonemo
reviewed
Dec 19, 2023
cryptonemo
reviewed
Dec 19, 2023
cryptonemo
reviewed
Dec 19, 2023
cryptonemo
previously approved these changes
Dec 19, 2023
vmx
changed the title
vmx
force-pushed
the
benchy-api-features-flag
branch
from
e4f774a
to
38528c3
Compare
|
I did a force push as the original commit message had a typo. I kept the |
Instead of passing in a boolean whether it's Synthetic PoRep or not, make it possible to pass in any supported feature.
vmx
force-pushed
the
benchy-api-features-flag
branch
from
38528c3
to
9e1a52e
Compare
DrPeterVanNostrand
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing in a boolean whether it's Synthetic PoRep or not, make it possible to pass in any supported feature.
This is a follow up of #1742 (comment).