Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of dependencies #79

Open
vmx opened this issue Dec 1, 2022 · 0 comments
Open

Reduce the number of dependencies #79

vmx opened this issue Dec 1, 2022 · 0 comments

Comments

@vmx
Copy link
Contributor

vmx commented Dec 1, 2022

Triggered by #78 I found that there are more dependencies that can easily be removed and hence reduce the maintenance burden.

  • bellperson is only needed for bellperson::groth16::aggregate::AggregateVersion. I suggest re-exporting it directly from filecoin-proofs, perhaps here: https://github.com/filecoin-project/rust-fil-proofs/blob/fbf3af067d9368fec2818f36fe2e2e7d5035d85b/filecoin-proofs/src/api/seal.rs. There we could add a re-export as pub roth16::aggregate::AggregateVersion. This would then bubble up automatically and could be used as use filecoin_proofs_v1::api::AggregateVersion.
  • blstrs is only needed for blstrs::Scalar. It can also be re-exported from filecoin-proofs, just like the AggregateVersion and then be used as filecoin_proofs_v1::api::Fr.
  • filecoin_hashers is only needed for filecoin_hashers::Hasher. Same thing as for the others, it would then be filecoin_proofs_v1::api::Hasher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant