chore: remove the dependency on storage-proofs-porep #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a dependency on `storage-proofs-porep`, but it isn't used anywhere in the source. I suspect that it was included in order to enable the `multicore-sdr` feature. But this feature can also be enabled through setting it on `filecoin-proofs-v1`, which will then set it on `storage-proofs-porep`. The same is true for the `cuda` and `opencl` features. This commit also updates the Xcode version on CI, so that the tests pass.
shawnrader
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a dependency on
storage-proofs-porep, but it isn't used anywhere in the source. I suspect that it was included in order to enable themulticore-sdrfeature. But this feature can also be enabled through setting it onfilecoin-proofs-v1, which will then set it onstorage-proofs-porep. The same is true for thecudaandopenclfeatures.