This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
feat: Allow VerifiedClient DataCap to be topped up #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anorth
approved these changes
Apr 6, 2021
There was a problem hiding this comment.
Looks good to me, but please wait for approval from @ZenGround0
| func (h *verifRegActorTestHarness) addVerifiedClient(rt *mock.Runtime, verifier, client address.Address, caps ...verifreg.DataCap) { | ||
| // caps[0] expects allowance to be set | ||
| // caps[1] (optional) expected allowance to be verified | ||
| // additional args are ignored |
There was a problem hiding this comment.
Fail the test rather than ignore an unexpected argument. Fail also if the slice has length zero.
Alternatively, I would be just as happy if the two args were explicit, and the usually-redundant expected cap was always explicitly passed.
There was a problem hiding this comment.
I want to change this to two explict arguments.
ZenGround0
reviewed
Apr 6, 2021
There was a problem hiding this comment.
Since your week of work is over @placer14 I'm taking this PR over. I'm going to make some changes to testing but the code change looks good.
| func (h *verifRegActorTestHarness) addVerifiedClient(rt *mock.Runtime, verifier, client address.Address, caps ...verifreg.DataCap) { | ||
| // caps[0] expects allowance to be set | ||
| // caps[1] (optional) expected allowance to be verified | ||
| // additional args are ignored |
There was a problem hiding this comment.
I want to change this to two explict arguments.
ZenGround0
force-pushed
the
mg/feat/fip0012-impl
branch
from
ca8050d to
c02e51f
Compare
ZenGround0
approved these changes
Apr 8, 2021
ZenGround0
added a commit
that referenced
this pull request
Apr 13, 2021
* feat: Allow VerifiedClient DataCap to be topped up * Modify tests Co-authored-by: ZenGround0 <ZenGround0@users.noreply.github.com>
ZenGround0
added a commit
that referenced
this pull request
Apr 27, 2021
* feat: Allow VerifiedClient DataCap to be topped up * Modify tests Co-authored-by: ZenGround0 <ZenGround0@users.noreply.github.com>
ZenGround0
added a commit
that referenced
this pull request
Apr 27, 2021
* feat: Allow VerifiedClient DataCap to be topped up * Modify tests Co-authored-by: ZenGround0 <ZenGround0@users.noreply.github.com>
ZenGround0
added a commit
that referenced
this pull request
Apr 27, 2021
* feat: Allow VerifiedClient DataCap to be topped up * Modify tests Co-authored-by: ZenGround0 <ZenGround0@users.noreply.github.com>
ZenGround0
added a commit
that referenced
this pull request
May 4, 2021
* v5 actors * feat: Adjust consensus fault reward to meet FIL-0011 * feat: Allow VerifiedClient DataCap to be topped up (#1390) * Remove out of date test * Update to go 1.16 * Remove old migration and simplify agent tests Co-authored-by: ZenGround0 <ZenGround0@users.noreply.github.com> Co-authored-by: Mike Greenberg <mike.greenberg@protocol.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements FIP-0012 and fixes #1325.
Thoughts on these changes:
addVerifiedClientfunction is now overloaded to support an optionalexpectedAllowancearg to be used in the cases where VerifiedClients will now have more than what was initially allotted. This makes the verification of anexpectedAllownacea concern on the caller rather than letting the function reflect on its internal before/after state to verify correctness. I'd personally prefer the latter to keep the call simple, but there were errors when I attempted to access the runtime map for the "before" state of the Client's DataCap allowance. (An example of that is at https://gist.github.com/placer14/f2134a4064373607da44b48b4f338d69.)