This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Introduce the v5 migration #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenGround0
reviewed
May 10, 2021
| return cid.Undef, err | ||
| } | ||
|
|
||
| // Setup synchronization |
There was a problem hiding this comment.
Since we don't expect any need for state migrations this concurrency is most likely overkill. This is especially true given the presence of premigrations. I'm going to simplify this accordingly.
nvm the state tree has gotten big and there is more risk associated with changing this code than keeping it.
ZenGround0
approved these changes
May 10, 2021
ZenGround0
force-pushed
the
asr/migration-v5
branch
from
ba284f3
to
1b6b158
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to bump the actor code CIDs (forgot to include this in #1401, sorry!)