This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Clarify market actor sector termination with expired deals #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1417 +/- ##
======================================
Coverage 69.8% 69.9%
======================================
Files 72 72
Lines 7792 7786 -6
======================================
Hits 5446 5446
+ Misses 1451 1448 -3
+ Partials 895 892 -3 |
ZenGround0
approved these changes
May 17, 2021
actors/builtin/market/market_test.go
Outdated
| @@ -1448,6 +1436,7 @@ func TestCronTick(t *testing.T) { | |||
| rt.ExpectAbort(exitcode.ErrNotFound, func() { | |||
| actor.cronTick(rt) | |||
| }) | |||
| //actor.checkState(rt) // cannot check state invariants | |||
There was a problem hiding this comment.
nit: this could be moved to assert the exact state invariants broken by calling CheckStateInvariants directly and asserting on the number and contents of the output messages.
anorth
changed the title
anorth
force-pushed
the
anorth/fixtermination
branch
from
47ae52f to
a77497c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1411 described a possible problem with the market actor handling termination of sectors after deals expire. I determined it's not a problem, but clarified and cleaned up associated code and tests here. This shows that
OnMinerSectorsTerminatedoes not abort if deals have expired. So this PR does not change actor behaviour.The first commit here adds return values to some of the mock runtime's setter methods, so that a value (like an epoch) can be set and assigned to a local variable in one line:
newValue = rt.SetEpoch(oldValue + delta).Closes #1411.