This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Set ConsensusMinerMinPower to 10 TiB for all PoStProofPolicies #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenGround0
approved these changes
May 20, 2021
actors/builtin/power/power_test.go
Outdated
| @@ -441,15 +441,16 @@ func TestPowerAndPledgeAccounting(t *testing.T) { | |||
|
|
|||
| power64Unit, err := builtin.ConsensusMinerMinPower(abi.RegisteredPoStProof_StackedDrgWindow64GiBV1) | |||
| require.NoError(t, err) | |||
| assert.True(t, power64Unit.GreaterThan(powerUnit)) | |||
|
|
|||
There was a problem hiding this comment.
Remove this subtest which is now testing deprecated behavior ("consensus power depends on proof type")
arajasek
force-pushed
the
asr/v4-actors-minpower
branch
from
0c7e093
to
249f914
Compare
Codecov Report
@@ Coverage Diff @@
## release/v4 #1430 +/- ##
============================================
- Coverage 65.1% 65.0% -0.1%
============================================
Files 81 81
Lines 8246 8246
============================================
- Hits 5370 5368 -2
- Misses 1984 1985 +1
- Partials 892 893 +1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lotus has been unintentionally overwriting this value to 10 TiB for all proof types since mainnet. We might as well reflect this behaviour in the actors code.