This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Fix seal proof type in miner actor and parameterize WPoSt partition size by it #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // The number of sectors in each Window PoSt partition (proof). | ||
| // This is computed from the proof type and represented here redundantly. | ||
| WindowPoStPartitionSectors uint64 |
There was a problem hiding this comment.
I guess its fine to put this here, since we never rewrite this.
There was a problem hiding this comment.
You could convince me to take it out pretty easily, but if it [the code that derives it] ever changed we'd be in trouble, and this helps make the state transparent.
whyrusleeping
approved these changes
Apr 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the way to #335. The registered proof types in all the sector states and messages are now redundant.
FYI @magik6k, @acruikshank