This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
decouple SealVerifyInfo from OnChainSealVerifyInfo (and rename to SealVerifyParams) #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laser
force-pushed
the
feat/adjusted-verification-iface
branch
from
32d2e68 to
04b73e0
Compare
anorth
approved these changes
May 14, 2020
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
+ Coverage 42.73% 42.77% +0.04%
==========================================
Files 40 40
Lines 4210 4213 +3
==========================================
+ Hits 1799 1802 +3
Misses 2151 2151
Partials 260 260 |
Sounds good. Please do let me know when it's safe to merge (or just merge it yourself) and I'll handle the filecoin-ffi side of things. |
laser
force-pushed
the
feat/adjusted-verification-iface
branch
from
2f18f4f to
698b8d2
Compare
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
+ Coverage 42.68% 42.72% +0.04%
==========================================
Files 40 40
Lines 4215 4218 +3
==========================================
+ Hits 1799 1802 +3
Misses 2156 2156
Partials 260 260 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why does this PR exist?
Fixes #276.
What's in this PR?
abi.SealVerifyInfono longer embeds theabi.OnChainSealVerifyInfo(it now mirrors the required fields from the original struct).OnChainSealVerifyInforenamed toSealVerifyParams.SealVerifyParamsmoved tominerpackage.