Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Revert "windowed post generation now returns faulty sectors" #13

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Sep 10, 2020

Reverts #12

It doesn't really make sense to treat skipped/faulty differently

Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesnt it? don't we want to use this information to adjust our next call to generate windowed post?

@anorth
Copy link
Member

anorth commented Sep 10, 2020

I agree with @magik6k, I think you need to know which sectors are going to fail before calling this, so you can then rework the sector infos to mask out the faulty sectors and try again.

I would propose a flow where:

  • this method fails quickly (after sampling) if any sector can't be challenged, and returns the failing sector ids or indices
  • the mining worker then adds them to the fault set, recomputes the arguments to this function, and tries again
  • after success, the mining worker propagates the skipped sector ids

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, skipped/faulty are the same thing. We can revisit this if that changes, but this patch is going to lead to interface churn for no good reason at the moment.

@Stebalien Stebalien merged commit 0d9eb43 into master Nov 5, 2020
@Stebalien
Copy link
Member

(merging because this is blocking other work)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants