FIL VM Message Validation Update #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anorth
reviewed
Aug 17, 2020
Co-authored-by: Alex North <445306+anorth@users.noreply.github.com>
|
@anorth I've done a pass and addressed most comments. Could you have another look and point out issues that need more description/highlighting? |
|
@anorth addressed comments, added link to the lotus repo and set the section's state to "stable", from "incomplete". |
anorth
previously approved these changes
Aug 20, 2020
|
Done final minor changes and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an update to the VM Message section. It does not include description of the gas fee calculation, which might need to go here - I'm not sure about this yet. A brief description will probably be included here anyway. This will be done in a subsequent commit or separate PR.