-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIL VM Runtime Interface Update #1064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I object to duplicating all this code and prose from the specs-actors repo. That repo is the spec, it was broken out from this one precisely to avoid the maintenance nightmare that will arise from having two versions of this, only one of which (the executable code) stands a chance of being correct.
Please link to the specs-actors repo instead. To the extent that prose can be improved, please do so with PRs to the specs-actors repo.
@anorth I've removed all redundant text and code and pointed to the respective repositories. Let me know if there's some part of the code that needs a special mention or description in text, so that I work to include it. |
@hugomrdias this is ready to merge. |
still targeting beta |
you didnt change the links yet |
@hugomrdias I did now :) |
9a3e2c4
to
29374da
Compare
This PR updates the specification for the FIL VM Runtime Interface & Exit codes.
I have excluded mention to the
vm/implementation
andcode loading
, as I found these parts too implementation-specific and therefore, not belonging to this spec. Let me know if we want to do otherwise and if so, which are the important points from those parts that we should be referring to.