Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(content): major update to the glossary content #1151

Merged
merged 13 commits into from
Sep 22, 2020
Merged

feat(content): major update to the glossary content #1151

merged 13 commits into from
Sep 22, 2020

Conversation

yiannisbot
Copy link
Collaborator

This is a major update to the terms and definitions of the Glossary section.

@yiannisbot yiannisbot marked this pull request as ready for review September 11, 2020 05:43
This was referenced Sep 15, 2020
Closed
Closed
hannahhoward
hannahhoward reviewed Sep 15, 2020
View reviewed changes
Copy link
Contributor

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments left. I dunno how blocking any of them are, other than the Piece description has some inaccuracies.

content/glossary/_index.md Outdated Show resolved Hide resolved
content/glossary/_index.md Outdated Show resolved Hide resolved
content/glossary/_index.md Outdated Show resolved Hide resolved
content/glossary/_index.md Show resolved Hide resolved
@rvagg rvagg mentioned this pull request Sep 18, 2020
Merged
@yiannisbot yiannisbot added hint: ready to merge Hint: PR is ready to be merged scope: content Scope: Editing content of the spec labels Sep 21, 2020
@hugomrdias hugomrdias changed the title Glossary Update feat(content): major update to the glossary content Sep 22, 2020
@hugomrdias hugomrdias merged commit e54ab6e into master Sep 22, 2020
@hugomrdias hugomrdias deleted the glossary-update branch September 22, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahhoward hannahhoward hannahhoward left review comments

@porcuquine porcuquine porcuquine left review comments

@hugomrdias hugomrdias hugomrdias approved these changes

@sa8 sa8 sa8 approved these changes

@nicola nicola Awaiting requested review from nicola

Assignees
No one assigned
Labels
hint: ready to merge Hint: PR is ready to be merged scope: content Scope: Editing content of the spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yiannisbot @hugomrdias @hannahhoward @porcuquine @sa8