Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content): remove sharded IPLD array file #1161

Merged
merged 3 commits into from
Sep 22, 2020
Merged

Conversation

yiannisbot
Copy link
Collaborator

The Sharded IPLD Arrays are not used in Filecoin anymore, hence, this PR removes the subsection from the Appendix.

@mikeal
Copy link

mikeal commented Sep 17, 2020

@rvagg should we pull any of this into the IPLD docs or specs site? We still have implementations of this, they just aren’t used in Filecoin anymore.

@yiannisbot
Copy link
Collaborator Author

If you think it's useful to keep in this spec, I suggest that we move it in the libraries section together with the rest of the IPLD stuff.

@rvagg
Copy link
Member

rvagg commented Sep 18, 2020

Our vector spec covers this well enough, I think it's already 1:1 (although slightly more configurable?) with sharray so I don't think we need to capture anything here. This will be a good one to get to with ipld-prime now that they're poking at ADLs but we have it covered with the spec and the sharray code.

@yiannisbot
Copy link
Collaborator Author

It sounds to me that this section is not needed in this spec. So, I suggest that: i) approve this PR and remove the section, ii) include any extra links and pointers, if needed, in the Libraries section with a PR there.

@yiannisbot yiannisbot added hint: ready to merge Hint: PR is ready to be merged scope: content Scope: Editing content of the spec labels Sep 21, 2020
@hugomrdias hugomrdias changed the title Removing sharded IPLD array file fix(content): remove sharded IPLD array file Sep 22, 2020
@hugomrdias hugomrdias merged commit d1b31ef into master Sep 22, 2020
@hugomrdias hugomrdias deleted the removing-sharray branch September 22, 2020 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hint: ready to merge Hint: PR is ready to be merged scope: content Scope: Editing content of the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants