feat(content): add implementations audits as a dedicated section in the spec #1214
Conversation
dkkapur
requested review from
hugomrdias,
yiannisbot,
dignifiedquire,
olizilla,
daviddias and
porcuquine
and removed request for
olizilla
Co-authored-by: Hugo Dias <hugomrdias@gmail.com>
content/implementations/lotus.md
Outdated
| @@ -19,9 +19,9 @@ implRepos: | |||
| auditState: done | |||
| audits: | |||
| - auditDate: '2020-07-28' | |||
| auditURL: https://github.com/filecoin-project/rust-fil-proofs/blob/master/audits/protocolai-audit-20200728.pdf | |||
| auditURL: /#appendix__audit_reports__rust-fil-proofs__filecoin-proving-subsystem | |||
There was a problem hiding this comment.
Can you paste a screenshot of what the dashboard looks like?
There was a problem hiding this comment.
you have the preview below
|
just made a few more changes based on @daviddias comments. @yiannisbot - here is what the dashboard looks like now:
|
|
can you please rebase onto master? |
|
@hugomrdias i think this one should be correctly rebased, please let me know if thats not true |
|
you merged instead of rebase now this PR has a bunch of changed files not related to these changes |
|
ah yes sorry - my 4am brain is being bad. should i scrap this PR, reset the head and reopen one? |
|
Basically the urls were wrong in yours changes. Please check now and copy paste the correct relative urls to the dashboard md file. |
|
@hugomrdias does it look right now? |
|
yep the link goes to the right section but opens in a new tab. |
|
@hugomrdias yes, that is the plan right now. will also add theory audits to this section in the next day (drand and gossipsub, both of which are linked in the main dashboard right now, and will follow the same process as here with the URLs). |
|
what should I do to the URL to not open in a new tab? |
|
Just please make an issue about audit relative urls opening in a new tab and i will fix it. Mention this PR once that issue is up i will merge this into master. Thank you great job. |
|
thank you! issue is up and this PR is mentioned. |
hugomrdias
changed the title
created an audits section in the appendix where we can collect the links to published audit reports and share them with short descriptions