feat: light mode with optional dark mode toggle #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the user to specify their prefered color-scheme. Fixes: #983 License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
|
@hugomrdias merge conflicts fixed up on this here color-scheme selector PR |
hugomrdias
previously approved these changes
Jul 23, 2020
|
@hugomrdias conflicts be gone |
|
ping @hugomrdias pls to eyes. |
hugomrdias
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to specify their prefered color-scheme. It will default to whatever the users OS color-scheme preference is.
Light mode
Dark mode
This is implemented by providing dark mode as an alternate stylesheet, and providing a toggle to let the user switch between the two. As the specs site is static, we can't rely on the server to maintain the chosen color-scheme, so we use local storage. If you have selected dark theme, you may see the light theme for a few milliseconds before we get the preference from localstorage to tell us to switch to dark mode. I've mitigated it as much as I can for this iteration, and as this is a very low priority feature, I'm not gonna explore it any further for now. It's more noticable in FF than Chromes.
Fixes: #983
License: MIT
Signed-off-by: Oli Evans oli@tableflip.io