Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: user data of chain-service isolation #346

Merged
merged 8 commits into from
Mar 1, 2023
Merged

docs: user data of chain-service isolation #346

merged 8 commits into from
Mar 1, 2023

Conversation

diwufeiwen
Copy link
Contributor

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前，需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 符合venus-docs文档规范
  • 具有清晰明确的commit message / All commits have a clear commit message.

@diwufeiwen diwufeiwen self-assigned this Oct 20, 2022
@diwufeiwen diwufeiwen marked this pull request as draft October 20, 2022 05:56
@Fatman13
Copy link
Contributor

@diwufeiwen t哥，这个文档看上去很设计，要不要试试这个新模版？[doge] 哈哈哈。

关联：

@Fatman13
Copy link
Contributor

可以“进阶”这个标签页下，专门开个“设计”二级菜单，放一些设计的东西？
image

@diwufeiwen
Copy link
Contributor Author

@diwufeiwen t哥，这个文档看上去很设计，要不要试试这个新模版？[doge] 哈哈哈。

关联：

可以套用模板，你去实践，这是个新的需求

@Fatman13
Copy link
Contributor

我套套看。我直接一起提在这个PR里面？😄

@diwufeiwen
Copy link
Contributor Author

可以，目前是草稿，谁都可以完善

@Fatman13 Fatman13 mentioned this pull request Oct 24, 2022
Merged
1 task
This was referenced Nov 4, 2022
Closed
Closed
@Fatman13 Fatman13 added the design Venus feature/system design issues label Nov 16, 2022
@Fatman13 Fatman13 mentioned this pull request Nov 18, 2022
Closed
39 tasks
@Fatman13 Fatman13 mentioned this pull request Dec 2, 2022
Closed
42 tasks
@Fatman13 Fatman13 mentioned this pull request Dec 16, 2022
Closed
36 tasks
@Fatman13 Fatman13 mentioned this pull request Dec 30, 2022
Closed
54 tasks
@Fatman13
Copy link
Contributor

这个是不是做好了？咱们合进去？CC @diwufeiwen

@LinZexiao
Copy link
Collaborator

这个是不是做好了？咱们合进去？CC @diwufeiwen

按照我们之前说的, 这个, 还需要我这边还会补充一些实现相关的内容

@Fatman13 Fatman13 mentioned this pull request Jan 18, 2023
Closed
39 tasks
@Fatman13 Fatman13 mentioned this pull request Feb 10, 2023
Closed
45 tasks
@Fatman13 Fatman13 mentioned this pull request Feb 24, 2023
Closed
38 tasks
@LinZexiao LinZexiao marked this pull request as ready for review March 1, 2023 07:56
Fatman13
Fatman13 approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@Fatman13 Fatman13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fatman13 Fatman13 merged commit 85ee22f into master Mar 1, 2023
@Fatman13 Fatman13 deleted the feat/docs_userdata_isolation branch March 1, 2023 07:59
@Fatman13 Fatman13 mentioned this pull request Mar 10, 2023
Closed
39 tasks
This was referenced Mar 24, 2023
Closed
Closed
@Fatman13 Fatman13 mentioned this pull request Apr 10, 2023
Closed
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fatman13 Fatman13 Fatman13 approved these changes

@LinZexiao LinZexiao Awaiting requested review from LinZexiao

Assignees

@diwufeiwen diwufeiwen

Labels
design Venus feature/system design issues
Projects
Venus Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@diwufeiwen @Fatman13 @LinZexiao @ta0li