feat: 重构消息推送及签名逻辑 / refactor sign & push-msg logic #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diwufeiwen
force-pushed
the
feat/lt/refactor_msg_push_api
branch
4 times, most recently
from
cf39953 to
9cc8312
Compare
diwufeiwen
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #241 +/- ##
==========================================
+ Coverage 53.98% 54.26% +0.27%
==========================================
Files 62 62
Lines 6576 6485 -91
==========================================
- Hits 3550 3519 -31
+ Misses 2745 2686 -59
+ Partials 281 280 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
simlecode
reviewed
Aug 24, 2022
| @@ -117,8 +114,6 @@ func fromMessage(srcMsg *types.Message) *mysqlMessage { | |||
| Height: srcMsg.Height, | |||
| Receipt: repo.FromMsgReceipt(srcMsg.Receipt), | |||
| Meta: mtypes.FromMeta(srcMsg.Meta), | |||
| WalletName: srcMsg.WalletName, | |||
There was a problem hiding this comment.
考虑留着？万一要回滚，没上链的消息就没有这两个值了
There was a problem hiding this comment.
在新的体系中venus-messager不应该存在WalletName这种东西，其签名都应该通过venus-gateway处理
There was a problem hiding this comment.
回滚的问题需要考虑到，不过真要是出问题，回滚程序也没用了，可能是要改数据库。
diwufeiwen
force-pushed
the
feat/lt/refactor_msg_push_api
branch
2 times, most recently
from
0d1a872 to
104cac9
Compare
20 tasks
simlecode
reviewed
Aug 31, 2022
diwufeiwen
force-pushed
the
feat/lt/refactor_msg_push_api
branch
10 times, most recently
from
723242f to
507509f
Compare
diwufeiwen
force-pushed
the
feat/lt/refactor_msg_push_api
branch
from
507509f to
bd58c40
Compare
diwufeiwen
force-pushed
the
feat/lt/refactor_msg_push_api
branch
from
bd58c40 to
f14043f
Compare
hunjixin
reviewed
Oct 9, 2022
hunjixin
reviewed
Oct 9, 2022
|
按计划给 release/v1.9.0-pre-rc1 分支合并，此pr关闭 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
关联的Issues (Related Issues)
close
改动 (Proposed Changes)
附注 (Additional Info)
自查清单 (Checklist)
在你认为本 PR 满足被审阅的标准之前，需要确保 / Before you mark the PR ready for review, please make sure that: