Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/lt/refactor msg push api #271

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

diwufeiwen
Copy link
Contributor

@diwufeiwen diwufeiwen commented Oct 25, 2022

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

附注 (Additional Info)

  • 回滚的问题(还是升级失败版本回退的问题?)
    simlecode on 24 Aug
    考虑留着?万一要回滚,没上链的消息就没有这两个值了

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@diwufeiwen diwufeiwen force-pushed the feat/lt/refactor_msg_push_api branch 3 times, most recently from 7012421 to 73101c5 Compare October 25, 2022 08:43
@diwufeiwen diwufeiwen force-pushed the feat/lt/refactor_msg_push_api branch from 73101c5 to f7a8f9e Compare November 1, 2022 08:32
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release/v1.9.0-pre-rc1@41db9c7). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                    @@
##             release/v1.9.0-pre-rc1     #271   +/-   ##
=========================================================
  Coverage                          ?   53.94%           
=========================================================
  Files                             ?       63           
  Lines                             ?     6670           
  Branches                          ?        0           
=========================================================
  Hits                              ?     3598           
  Misses                            ?     2780           
  Partials                          ?      292           
Flag Coverage Δ
unittests 53.94% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@diwufeiwen diwufeiwen force-pushed the feat/lt/refactor_msg_push_api branch 9 times, most recently from 1932ed7 to 9c4196a Compare November 3, 2022 03:59
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

@simlecode simlecode merged commit aaca684 into release/v1.9.0-pre-rc1 Nov 8, 2022
@simlecode simlecode deleted the feat/lt/refactor_msg_push_api branch November 8, 2022 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

4 participants