-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/lt/refactor msg push api #271
Merged
simlecode
merged 3 commits into
release/v1.9.0-pre-rc1
from
feat/lt/refactor_msg_push_api
Nov 8, 2022
Merged
Feat/lt/refactor msg push api #271
simlecode
merged 3 commits into
release/v1.9.0-pre-rc1
from
feat/lt/refactor_msg_push_api
Nov 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7012421
to
73101c5
Compare
73101c5
to
f7a8f9e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/v1.9.0-pre-rc1 #271 +/- ##
=========================================================
Coverage ? 53.94%
=========================================================
Files ? 63
Lines ? 6670
Branches ? 0
=========================================================
Hits ? 3598
Misses ? 2780
Partials ? 292
Flags with carried forward coverage won't be shown. Click here to find out more. |
1932ed7
to
9c4196a
Compare
9c4196a
to
08c1537
Compare
20 tasks
simlecode
reviewed
Nov 7, 2022
simlecode
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
关联的Issues (Related Issues)
close
改动 (Proposed Changes)
附注 (Additional Info)
simlecode on 24 Aug
考虑留着?万一要回滚,没上链的消息就没有这两个值了
自查清单 (Checklist)
在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that: