Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add password verification for api-info command #160

Merged
merged 2 commits into from
Oct 31, 2023
Merged

feat: add password verification for api-info command #160

merged 2 commits into from
Oct 31, 2023

Conversation

Aloxaf
Copy link
Contributor

@Aloxaf Aloxaf commented Oct 26, 2023

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

考虑到 sign、export、del 等命令直接使用时都需要进行密码验证

在使用 auth api-info 命令生成具有 admin/sign 权限的 token 时,也应该进行密码验证。

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Merging #160 (ca9ad47) into master (1c0949a) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
- Coverage   34.46%   34.26%   -0.20%     
==========================================
  Files          41       41              
  Lines        2591     2606      +15     
==========================================
  Hits          893      893              
- Misses       1542     1557      +15     
  Partials      156      156              
Flag Coverage Δ
unittests 34.26% <0.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cli/auth.go 0.00% <0.00%> (ø)

Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simlecode simlecode merged commit 2ba38f8 into filecoin-project:master Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants